Merged
Conversation
the test on line 327 in `src/athena/generator/compose.rs` is checking
that the generated YAML does not contain a `version:` field:
```rust
assert!(!yaml.contains("version:"));
```
This test is actually validating that the version field has been
properly removed from the Docker Compose output.
…ure to make the tests more understandable.
Enhanced test structure: - 67 integration tests organized by functionality (CLI, Docker generation, boilerplate, structural) - Lightweight structural tests focusing on logic over format (no heavy snapshot tests) - Modular boilerplate tests by framework (FastAPI, Go, Flask) Addition of documentation and modification of the readme file ``` docs/ ├── INSTALLATION.md # Complete installation guide (Makefile, Windows, manual) ├── DSL_REFERENCE.md # Complete DSL syntax and directives reference ├── EXAMPLES.md # Practical .ath file examples ├── BOILERPLATE.md # Project generator documentation ├── ARCHITECTURE.md # System design and components ├── DEVELOPMENT.md # Contributing and development workflow └── TESTING.md # Comprehensive test suite documentation ```
1. Port conflict detection `compose.rs`
- Automatically detects duplicate host ports between services
- Clear error messages with alternative port suggestions
2. Comprehensive integration tests
`tests/integration/error_handling_test.rs`
- 4 new integration tests following the documented structure
- Tests via CLI with `assert_cmd` and `predicates`
- Fixture files created in `tests/fixtures/`
3. Maintained unit tests - compose.rs:tests
- Tests for the `extract_host_port()` and `generate_port_suggestions()`
utility functions
- Basic generation test maintained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.